On 10/11/19 9:41 AM, AKASHI Takahiro wrote:
Adding "printk.h" will help improve portability from linux kernel
code (in my case, lib/asn1_decoder.c).

Signed-off-by: AKASHI Takahiro <takahiro.aka...@linaro.org>
---
  include/linux/kernel.h | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index a85c15d8dc28..919d12bdf89c 100644
--- a/include/linux/kernel.h
+++ b/include/linux/kernel.h
@@ -2,7 +2,9 @@
  #define _LINUX_KERNEL_H


+#include <vsprintf.h> /* for printf utilities */

Kernel code has no vsprintf.h. Linux's lib/asn1_decoder.c has not a
single print statement. So why are you inserting vsprintf.h here?

  #include <linux/types.h>
+#include <linux/printk.h>

Linux include/linux/kernel.h also includes printk.h. OK.

Best regards

Heinrich

  #define USHRT_MAX     ((u16)(~0U))
  #define SHRT_MAX      ((s16)(USHRT_MAX>>1))


_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Reply via email to