Am 2019-10-14 15:29, schrieb Michal Simek:
From: Siva Durga Prasad Paladugu <[email protected]>
This patch adds support for fru commands "fru capture" and "fru
display".
The fru capture parses the FRU table present at an address and stores
in a
structure for later use. The fru display prints the content of captured
structured in a readable format.
As of now, it supports only common header and board area of FRU. Also,
it
supports only English language code and ASCII8 format.
fru_data variable is placed to data section because fru parser can be
called very early before bss is initialized. And also information needs
to
be shared that's why it is exported via header.
Wouldn't it make more sense to have a level of indirection so other
"fru" formats might be supported as well. As far as I can see, only
"your" type of FRU data is supported by this command and there is now
way to extend it.
Also why do the user have to manually do a "fru capture"? The use case
is to display any FRU data, correct? So from a users perspective a "fru
display" be sufficient to display the data.
-michael
_______________________________________________
U-Boot mailing list
[email protected]
https://lists.denx.de/listinfo/u-boot
