Le 12/07/2010 07:45, Prafulla Wadaskar a écrit : >> --- a/arch/arm/include/asm/arch-kirkwood/kirkwood.h >> +++ b/arch/arm/include/asm/arch-kirkwood/kirkwood.h
>> +#if defined (CONFIG_MV_EGIGA) > > I think you don't need ifdef here > >> +#define MV_EGIGA0_BASE KW_EGIGA0_BASE >> +#define MV_EGIGA1_BASE KW_EGIGA1_BASE >> +#endif Actually the ifdef is intended to make sure these symbols do not get defined uselessly for kirkwood boards that don't have Ethernet support. Granted, their being defined without being used is no big deal. However the whole thing about the egiga driver supporting one or two ports could be streamlined (e.g., one might define KIRKWOOD_EGIGAn_BASE while not enabling port n in CONFIG_KIRKWOOD_EGIGA_PORTS) and integrate the suggestion about the PHYs that occurred some time ago: <http://lists.denx.de/pipermail/u-boot/2010-June/073138.html> So I'll leave that one to a later patch set. Amicalement, -- Albert. _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
