Dear Bin： I have a suggetion that the acpi specification definition such as all acpi table structure definition should be place in /include directory. and write_acpi_tables function can be placed in platform directory. Creating acpi table mothod can be diffrent between x86 and arm.
Thank you Steven Hao 获取 Outlook for iOS<https://aka.ms/o0ukef> ________________________________ 发件人: Bin Meng <[email protected]> 发送时间: Monday, November 25, 2019 10:13:40 AM 收件人: Steven Hao <[email protected]> 抄送: [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; Andy Shevchenko <[email protected]> 主题: Re: [PATCH v3] arm: add acpi support for the arm Hi Steven, On Mon, Nov 25, 2019 at 10:09 AM Steven Hao <[email protected]> wrote: > > Dear Bin： > > Firstly： > I know that acpi about x86 is existing. And it is usefull for x86 platfporm. > If it is used to arm platform，some modification may have to do. For > example，facs table is useless for arm. > > In adition，The acpi table is writed statically and then modified dynamically > in my patch. It is a new method. > > I want to consult that whether my method is helpful or not. > > Secondly： > If i want to reuse the x86-acpi. I will overwrite the write_acpi_tables > function. But the definition about acpi strcuture is placed in > arch/x86/include/asm directory. It can not be used to arm plateform. If the > acpi library need to surport for all platform，i think it should move to > /include directory. > Yes, we all are aware that modifications are needed to the existing x86 ACPI support to support ARM. We don't want to create 2 ACP implementation in U-Boot. Regards, Bin _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
