>-----Original Message----- >From: Stefan Roese <[email protected]> >Sent: Monday, December 2, 2019 1:29 PM >To: Peng Ma <[email protected]>; Priyanka Jain <[email protected]>; >[email protected]; Ruchika Gupta <[email protected]>; Shengzhou Liu ><[email protected]> >Cc: Yinbo Zhu <[email protected]>; Z.q. Hou <[email protected]>; >[email protected]; [email protected]; [email protected]; >[email protected]; Andy Tang <[email protected]>; [email protected] >Subject: Re: [v2 1/5] Revert "ata: fsl_ahci: Add sata DM support for Freescale >powerpc socs" > >Hi Peng, > >On 02.12.19 04:40, Peng Ma wrote: >> This reverts commit 1ee494291880fd51ef0c5f7342e072bdb069d7ff. >> >> Commit 1ee494291880 ("ata: fsl_ahci: Add sata DM support for Freescale >> powerpc socs") introduced SCSI layer to call AHCI private API in order >> to support sata operations, In DM mode, This is not necessary for >> non-AHCI sata. So revert it and have already updated the driver itself >> to operate sata directly. >> >> Signed-off-by: Peng Ma <[email protected]> >> --- >> Changed for v2: >> - Add detailed explanation. > >Thanks for adding a more detailed decription here. But at first glance I still >failed to unterstand this. What's missing is (at least for me), that you >explain >that you added a new DM enabled SATA driver to support this controller [1] >which makes this AHCI driver superfluous. > >Is this explanation correct? > >If yes, then feel free to add my: > >Reviewed-by: Stefan Roese <[email protected]> > >to the complete patchset. > >Thanks, >Stefan > <snip> There are many merge conflicts Kindly rebase the series to top of tree(next branch) and also add "Reviewed-by: Stefan Roese <[email protected]> "in all patches.
Thanks Priyanka
