Hi Lukasz, On Sun, 17 Nov 2019 at 13:54, Lukasz Majewski <[email protected]> wrote: > > Hi Simon, > > > Hi Simon, > > > > > Hi Lukasz, > > > > > > On Mon, 14 Oct 2019 at 06:41, Lukasz Majewski <[email protected]> > > > wrote: > > > > > > > > Hi Simon, > > > > > > > > > Hi Lukasz, > > > > > > > > > > On Wed, 9 Oct 2019 at 03:02, Lukasz Majewski <[email protected]> > > > > > wrote: > > > > > > > > > > > > Dear Tom, > > > > > > > > > > > > > This define indicates if DM_GPIO shall be supported in SPL. > > > > > > > This allows proper operation of DM converted GPIO drivers in > > > > > > > SPL, which use boards. > > > > > > > > > > > > > > Signed-off-by: Lukasz Majewski <[email protected]> > > > > > > > --- > > > > > > > > > > > > > > Changes in v2: > > > > > > > - Add dependency on DM_GPIO > > > > > > > > > > > > > > > > > > > Tom, are there any issues preventing this patch from being > > > > > > applied to -master? > > > > > > > > > > This does not actually define DM_GPIO anywhere though, so this > > > > > is unused. > > > > > > > > The goal of this patch is to introduce in Kconfig a > > > > CONFIG_SPL_DM_GPIO. This define would be needed anyway, no matter > > > > if you perform the changes from [1]. > > > > > > > > This Kconfig define is necessary for the XEA board (i.MX28 based > > > > one), which uses OF_PLATDATA in SPL excessively to fit into size > > > > constraints. > > > > > > > > To be more precise the mxs_gpio.c driver uses > > > > #if CONFIG_IS_ENABLED(DM_GPIO) to provide DM GPIO support in SPL > > > > with OF_PLATDATA. > > > > > > > > > > > > > > > > > > As it happens I sent a similar patch[1], but it doesn't work. > > > > > I'll try again. > > > > > > > > It would be great if we could have [1] not causing build breaks. > > > > However, for my used case it would be enough to have the Kconfig > > > > definition of CONFIG_SPL_DM_GPIO (as I'm using OF_PLATDATA) with > > > > it. > > > > > > > > Simon, if you don't have time to do the fix for [1] I would opt > > > > for pulling this patch (to just add proper Kconfig define). > > > > > > I have had a crack at this here: > > > > > > https://gitlab.denx.de/u-boot/custodians/u-boot-dm/commit/a6d15bbd9e4e7684dd47d21817df85915f28cbab > > > > > > I expect to send this series along with this patch at the end of > > > this week. > > > > If I may ask - have you made any progress on this? > > In fact it blocks some i.MX28 related code (board to be precise) from > sending it upstream as converted drivers expect SPL_DM_GPIO to be > defined in Kconfig. > > In fact I do just need following code: > https://patchwork.ozlabs.org/patch/1169013/ > > If you have some difficulties to solve (on e.g. other archs) then maybe > it would be enough to pull the above patch?
Just getting back to this, but see U-Boot next which has the full patch now. Regards, Simon
