On Wed, Dec 04, 2019 at 10:36:47AM +0000, Peng Ma wrote: > If we didn't unbind the sata from block device, the same devices would > be added after sata remove, > This patch is to resolve this issue as below: > > => sata info > SATA#0: > (3.0 Gbps) > SATA#1: > (3.0 Gbps) > Device 0: Model: INTEL SSDSA2BW300G3D Firm: 4PC10362 Ser#: BTPR247005PY30 > Type: Hard Disk > Supports 48-bit addressing > Capacity: 286168.1 MB = 279.4 GB (586072368 x 512) > Device 1: Model: INTEL SSDSA2BW300G3D Firm: 4PC10362 Ser#: BTPR247005VX30 > Type: Hard Disk > Supports 48-bit addressing > Capacity: 286168.1 MB = 279.4 GB (586072368 x 512) > => sata stop > => sata info > SATA#0: > (3.0 Gbps) > SATA#1: > (3.0 Gbps) > Device 0: Model: INTEL SSDSA2BW300G3D Firm: 4PC10362 Ser#: BTPR247005PY300 > Type: Hard Disk > Supports 48-bit addressing > Capacity: 286168.1 MB = 279.4 GB (586072368 x 512) > Device 1: Model: INTEL SSDSA2BW300G3D Firm: 4PC10362 Ser#: BTPR247005VX300 > Type: Hard Disk > Supports 48-bit addressing > Capacity: 286168.1 MB = 279.4 GB (586072368 x 512) > Device 2: Model: INTEL SSDSA2BW300G3D Firm: 4PC10362 Ser#: BTPR247005PY300 > Type: Hard Disk > Supports 48-bit addressing > Capacity: 286168.1 MB = 279.4 GB (586072368 x 512) > Device 3: Model: INTEL SSDSA2BW300G3D Firm: 4PC10362 Ser#: BTPR247005VX300 > Type: Hard Disk > Supports 48-bit addressing > Capacity: 286168.1 MB = 279.4 GB (586072368 x 512) > > Signed-off-by: Peng Ma <[email protected]> > Reviewed-by: Simon Glass <[email protected]>
This is a correct bug fix, yes. It also causes size growth on tbs2910 that is in turn fatal on CI. For the moment I'm setting this patch aside so that I can take the rest of the series and figure out what to do with tbs2910 again afterwards. -- Tom
signature.asc
Description: PGP signature
