Hi Patrick, On Thu, 9 Jan 2020 at 23:30, Patrick DELAUNAY <[email protected]> wrote: > > Hi Simon, > > > From: Simon Glass <[email protected]> > > Sent: lundi 30 décembre 2019 02:21 > > > > On Tue, 26 Nov 2019 at 01:49, Patrick Delaunay <[email protected]> > > wrote: > > > > > > Add a simple pincontrol associated to the sandbox gpio driver, that > > > allows to check pin configuration with the command pinmux. > > > > > > The pmux test is also updated to test behavior with 2 pincontrols. > > > > > > Example to check LED pin configuration: > > > > > > => pinmux list > > > | Device | Driver | Parent > > > | pinctrl-gpio | sandbox_pinctrl_gpio | > > > root_driver > > > | pinctrl | sandbox_pinctrl | > > > root_driver > > > > > > => pinmux dev pinctrl-gpio > > > > > > => pinmux status > > > > > > a0 : gpio input . > > > a1 : gpio input . > > > a2 : gpio input . > > > a3 : gpio input . > > > a4 : gpio input . > > > a5 : gpio output . > > > a6 : gpio output . > > > ... > > > > > > Serie-cc: Heiko Schocher <[email protected]> > > > Serie-cc: Simon Glass <[email protected]> > > > > Series-cc :-) > > Oups :-) > > > > > > > > Signed-off-by: Patrick Delaunay <[email protected]> > > > > > > --- > > > > > > Changes in v2: > > > - Adapt sandbox_pinctrl_gpio driver with the saved dir_flags in > > > sandbox gpio driver > > > - rebase on v2020.01-rc3 > > > > > > arch/sandbox/dts/test.dts | 48 +++++---- > > > drivers/gpio/sandbox.c | 195 +++++++++++++++++++++++++++++++++++ > > > test/py/tests/test_pinmux.py | 10 ++ > > > 3 files changed, 231 insertions(+), 22 deletions(-) > > > > Reviewed-by: Simon Glass <[email protected]> > > Thanks for the review > > I am preparing a v3. > > Do you think I need to split the patch > [PATCH v2 08/14] gpio: add ops for configuration with dir flags >
I am in favour of that. Regards, Simon
