Hi Joel,
On Sat, Jan 11 2020, Joel Johnson wrote:
> Add reasonable default SPI offsets and ENV size when configured to
> boot from SPI flash.
>
> Signed-off-by: Joel Johnson <mrj...@lixil.net>
> ---
>
> board/solidrun/clearfog/Kconfig | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/board/solidrun/clearfog/Kconfig b/board/solidrun/clearfog/Kconfig
> index fd880ee591..ce7fcf653f 100644
> --- a/board/solidrun/clearfog/Kconfig
> +++ b/board/solidrun/clearfog/Kconfig
> @@ -37,4 +37,16 @@ config CLEARFOG_2GB_SOM
> Enable support for the 2GB RAM SOM variant. If this option is not
> enabled then the more common 1GB version will be used.
>
> +config ENV_SECT_SIZE
> + hex "Environment Sector-Size"
> + # Use SPI flash erase block size of 4 KiB
> + default 0x1000 if MVEBU_SPL_BOOT_DEVICE_SPI
> + # Use optimistic 64 KiB erase block, will vary between actual media
> + default 0x10000 if MVEBU_SPL_BOOT_DEVICE_MMC
Duplication of config symbols in platform specific Kconfig goes against
common practice. Platform specific values should go in
defconfig. Support for Clearfog SPI boot should be in a dedicated
defconfig, I think.
Same comment on patches #9 and #10.
> +config SYS_SPI_U_BOOT_OFFS
> + hex "address of u-boot payload in SPI flash"
> + default 0x20000
> + depends on MVEBU_SPL_BOOT_DEVICE_SPI
It might be better to add u-boot,spl-payload-offset property to the
U-Boot specific -u-boot.dtsi file instead.
> +
> endmenu
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- bar...@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
