Re: [PATCH 1/1] watchdog: cannot select CONFIG_CONFIG_MPC8xx_WATCHDOG

[Tom Rini]

On Sat, Jan 25, 2020 at 08:23:50PM +0100, Heinrich Schuchardt wrote:

> There is no configuration option CONFIG_CONFIG_MPC8xx_WATCHDOG. So we
> should not try to select it.
> 
> The select statement was introduced in a patch that was meant to only sort
> config options without changing them.
> 
> Fixes: b3134ffbd944 ("watchdog: Kconfig: Sort entry alphabetically")
> Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de>
> ---
>  drivers/watchdog/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 2b8064dfae..8b65b5a88c 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -103,7 +103,6 @@ config WDT_CDNS
>  config WDT_MPC8xx
>       bool "MPC8xx watchdog timer support"
>       depends on WDT && MPC8xx
> -     select CONFIG_MPC8xx_WATCHDOG
>       help
>          Select this to enable mpc8xx watchdog timer

A bit of looking in 'git log' and I think
f3729ba6e7b2dff9a6f6e72e8839d99c2e3dbb03 was incomplete, probably due to
using 'select CONFIG_...' here rather than just 'select
MPC8xx_WATCHDOG'.  Can you please finish the migration of things here?
Thanks!

-- 
Tom

signature.asc
Description: PGP signature