Re: [PATCH 1/1] pci: definition of pci_addr_t and pci_size_t

[Heinrich Schuchardt]

On 2/5/20 9:05 PM, Simon Glass wrote:

Hi Heinrich,

On Wed, 5 Feb 2020 at 12:07, Heinrich Schuchardt <xypron.g...@gmx.de> wrote:

Currently the size of pci_addr_t and pci_size_t depends on
CONFIG_SYS_PCI_64BIT. For qemu_arm64_defconfig with 4 GiB RAM this leads
to an error

     pci_hose_phys_to_bus: invalid physical address

which is due to the truncation of the bus address in _dm_pci_phys_to_bus.

Defining CONFIG_SYS_PCI_64BIT is not a solution as this results in an error

    PCI: Failed autoconfig bar 10

So let's use unsigned long for pci_addr_t and pci_size_t.

But how will this work on x86 where we might have 32-bit U-Boot but
need 64-bit PCI addresses?

Regards,
Simon

So would you suggest to only change the code for CONFIG_SYS_PCI_64BIT=n?

Best regards

Heinrich