On 10. 02. 20 13:07, Grygorii Strashko wrote: > > > On 07/02/2020 13:31, Michal Simek wrote: >> There is no reason to check sgmii branch again when it is clear that phy >> interface is rgmii. >> >> Signed-off-by: Michal Simek <[email protected]> >> --- >> >> drivers/net/phy/dp83867.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c >> index 4d796e289c45..3178787ff1c7 100644 >> --- a/drivers/net/phy/dp83867.c >> +++ b/drivers/net/phy/dp83867.c >> @@ -327,9 +327,7 @@ static int dp83867_config(struct phy_device *phydev) >> phy_write_mmd(phydev, DP83867_DEVADDR, >> DP83867_RGMIIDCTL, delay); >> - } >> - >> - if (phy_interface_is_sgmii(phydev)) { >> + } else if (phy_interface_is_sgmii(phydev)) { >> phy_write(phydev, MDIO_DEVAD_NONE, MII_BMCR, >> (BMCR_ANENABLE | BMCR_FULLDPLX | BMCR_SPEED1000)); >> > > From one side I have no objections, but from another - I'd prefer to > keep as is.
Can you please be elaborate on this one more? Thanks, Michal
