On Tue, 18 Feb 2020 at 19:44, Heinrich Schuchardt <xypron.g...@gmx.de> wrote:
> > > On 2/18/20 11:26 AM, Sughosh Ganu wrote: > > > > On Sat, 15 Feb 2020 at 04:04, Heinrich Schuchardt <xypron.g...@gmx.de > > <mailto:xypron.g...@gmx.de>> wrote: > > > > Do not use quotation marks for Kconfig help text. > > Replace rng abbreviation by full words. > > > > Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de > > <mailto:xypron.g...@gmx.de>> > > --- > > lib/efi_loader/Kconfig | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig > > index a7afa3f29e..84a4a35d80 100644 > > --- a/lib/efi_loader/Kconfig > > +++ b/lib/efi_loader/Kconfig > > @@ -127,7 +127,7 @@ config EFI_RNG_PROTOCOL > > bool "EFI_RNG_PROTOCOL support" > > depends on DM_RNG > > help > > - "Support for EFI_RNG_PROTOCOL implementation. Uses the rng > > - device on the platform" > > + Provide a EFI_RNG_PROTOCOL implementation using the > > hardware random > > + number generator of the platform. > > > > > > Should we mention the word hardware in the sentence. Can it simply be > > stated as "random number generator". I know that the existing sentence > > too uses "rng device" which has hardware connotations. But the protocol > > can also be used with a pseudo random number generator as well. > > > > -sughosh > > Chapter 37.5 Random Number Generator Protocol of the UEFI mentions that > if this protocol uses a deterministic RNG it must be based on a source > of raw entropy. > > So I think "using the hardware random number generator of the platform" > is accurate. > Yes. Makes sense. Acked-by: Sughosh Ganu <sughosh.g...@linaro.org> -sughosh