On 2/20/20 3:12 AM, Ang, Chee Hong wrote: >> On 2/19/20 1:25 PM, [email protected] wrote: >>> From: Chee Hong Ang <[email protected]> >>> >>> CONFIG_OF_EMBED was primarily enabled to support the agilex spl hex >>> file requirements. Since this option now produces a warning during >>> build, and the spl hex can be created using alternate methods, >>> CONFIG_OF_EMBED is no longer needed. >>> >>> Signed-off-by: Chee Hong Ang <[email protected]> >> >> If I apply just this patch, is the platform still bootable ? > Yes. I tested on the platform. > There is a similar patch from Dalon for Stratix10 and it still yet to be > applied > to mainline: > https://lists.denx.de/pipermail/u-boot/2019-September/384906.html > > I hope the patch from Dalon get applied to mainline before these patchsets. > > In fact, this "CONFIG_OF_EMBED" produce warning during build. > Better get rid of this.
If you just remove OF_EMBED, will the DT still be correctly passed in ? The warning is there for a reason and just removing OF_EMBED to silence the warning isn't the right approach. But if this works on Agilex, fine.
