Re: [PATCH v3 6/6] configs: ls1028a: enable the Ethernet switch driver in defconfig

[Alexandru Marginean]

On 3/13/2020 3:33 PM, Vladimir Oltean wrote:
On Tue, 3 Dec 2019 at 17:23, Alex Marginean <alexandru.margin...@nxp.com> wrote:

The switch driver for LS1028A Ethernet switch is now compiled in for
both LS1028A boards.

Signed-off-by: Alex Marginean <alexandru.margin...@nxp.com>
---
  configs/ls1028aqds_tfa_SECURE_BOOT_defconfig | 3 ++-
  configs/ls1028aqds_tfa_defconfig             | 3 ++-
  configs/ls1028ardb_tfa_SECURE_BOOT_defconfig | 3 ++-
  configs/ls1028ardb_tfa_defconfig             | 3 ++-
  4 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/configs/ls1028aqds_tfa_SECURE_BOOT_defconfig 
b/configs/ls1028aqds_tfa_SECURE_BOOT_defconfig
index 4a01cd6715..65e467817e 100644
--- a/configs/ls1028aqds_tfa_SECURE_BOOT_defconfig
+++ b/configs/ls1028aqds_tfa_SECURE_BOOT_defconfig
@@ -50,8 +50,9 @@ CONFIG_PHY_ATHEROS=y
  CONFIG_PHY_VITESSE=y
  CONFIG_DM_ETH=y
  CONFIG_DM_MDIO=y
+CONFIG_DM_DSA=y
  CONFIG_E1000=y
-CONFIG_FSL_ENETC=y

You surely didn't want to disable FSL_ENETC here, no?

I think there's a dependency set and ENETC is implied if FELIX_SWITCH is 
enabled.  I saved these with savedefconfig, I didn't manually edit them.

Alex


+CONFIG_MSCC_FELIX_SWITCH=y
  CONFIG_PCI=y
  CONFIG_DM_PCI=y
  CONFIG_DM_PCI_COMPAT=y
diff --git a/configs/ls1028aqds_tfa_defconfig b/configs/ls1028aqds_tfa_defconfig
index 1307f0d951..40d259d907 100644
--- a/configs/ls1028aqds_tfa_defconfig
+++ b/configs/ls1028aqds_tfa_defconfig
@@ -56,8 +56,9 @@ CONFIG_PHY_ATHEROS=y
  CONFIG_PHY_VITESSE=y
  CONFIG_DM_ETH=y
  CONFIG_DM_MDIO=y
+CONFIG_DM_DSA=y
  CONFIG_E1000=y
-CONFIG_FSL_ENETC=y
+CONFIG_MSCC_FELIX_SWITCH=y
  CONFIG_PCI=y
  CONFIG_DM_PCI=y
  CONFIG_DM_PCI_COMPAT=y
diff --git a/configs/ls1028ardb_tfa_SECURE_BOOT_defconfig 
b/configs/ls1028ardb_tfa_SECURE_BOOT_defconfig
index d0a3310a4c..f54a6da31b 100644
--- a/configs/ls1028ardb_tfa_SECURE_BOOT_defconfig
+++ b/configs/ls1028ardb_tfa_SECURE_BOOT_defconfig
@@ -49,9 +49,10 @@ CONFIG_PHY_ATHEROS=y
  CONFIG_PHY_VITESSE=y
  CONFIG_DM_ETH=y
  CONFIG_DM_MDIO=y
+CONFIG_DM_DSA=y
  CONFIG_PHY_GIGE=y
  CONFIG_E1000=y
-CONFIG_FSL_ENETC=y
+CONFIG_MSCC_FELIX_SWITCH=y
  CONFIG_PCI=y
  CONFIG_DM_PCI=y
  CONFIG_DM_PCI_COMPAT=y
diff --git a/configs/ls1028ardb_tfa_defconfig b/configs/ls1028ardb_tfa_defconfig
index 4ec7ed0920..e018e5a50e 100644
--- a/configs/ls1028ardb_tfa_defconfig
+++ b/configs/ls1028ardb_tfa_defconfig
@@ -56,9 +56,10 @@ CONFIG_PHY_ATHEROS=y
  CONFIG_PHY_VITESSE=y
  CONFIG_DM_ETH=y
  CONFIG_DM_MDIO=y
+CONFIG_DM_DSA=y
  CONFIG_PHY_GIGE=y
  CONFIG_E1000=y
-CONFIG_FSL_ENETC=y
+CONFIG_MSCC_FELIX_SWITCH=y
  CONFIG_PCI=y
  CONFIG_DM_PCI=y
  CONFIG_DM_PCI_COMPAT=y
--
2.17.1


Regards,
-Vladimir