-----Original Message----- From: Tom Warren Sent: Tuesday, March 17, 2020 10:43 AM To: Stephen Warren <swar...@wwwdotorg.org> Cc: u-boot@lists.denx.de; Stephen Warren <swar...@nvidia.com>; tomcwarren3...@gmail.com Subject: RE: [PATCH 1/5] ARM: tegra: rework fdt_serial_tag_setup_one
-----Original Message----- From: Stephen Warren <swar...@wwwdotorg.org> Sent: Tuesday, March 17, 2020 10:18 AM To: Tom Warren <twar...@nvidia.com> Cc: u-boot@lists.denx.de; Stephen Warren <swar...@nvidia.com> Subject: Re: [PATCH 1/5] ARM: tegra: rework fdt_serial_tag_setup_one External email: Use caution opening links or attachments On 3/17/20 11:16 AM, Stephen Warren wrote: > On 3/16/20 1:40 PM, twar...@nvidia.com wrote: >> From: Stephen Warren <swar...@nvidia.com> >> >> Reword fdt_serial_tag_setup_one() so that the types it uses aren't >> tied to CONFIG_SERIAL_TAG, and rename the function to better indicate >> its purpose. This will allow it to be re-used by future board info >> related code. > >> arch/arm/mach-tegra/ft_board_info.c | 77 >> +++++++++++++++++++++++++++++++++++++ >> arch/arm/mach-tegra/ft_board_info.h | 23 +++++++++++ > > I don't think this series was based on upstream, or there are missing > patches in between upstream and this series; those files don't exist > upstream. Oh. This patch adds those files. But the commit description says it's reworking some existing logic. I guess the description is from some squashed patch, and doesn't describe what the patch actually does? Also, the new file isn't added to any Makefile, and no edits are made to any other file in order to call the newly added functionality. [Tom] Yeah, this got messed up when I squashed/edited the transition from nvtboot to cboot support files in arch/arm/mach-tegra. I'll have to revisit this, as the code isn't called anywhere currently in my upstream work, nor build by a Makefile. [Tom] OK, so this work (adding board info (proc/pmu/display) is already done by CBoot on T210 before we get to U-Boot, so it's not needed. Mea culpa - lots of churn w/these patches, trying to get them squashed/optimized for upstreaming, and I mistakenly kept this one around from the nvtboot->U-Boot days. I'll drop it. ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. -----------------------------------------------------------------------------------
