On 2/12/20 7:37 PM, Patrick Delaunay wrote: > Remove the test offs < 0 , as offs is unsigned. > > This patch solves the warnings when compiling with W=1 > on stm32mp1 board: > > In function ‘stm32mp_bsec_read’: > arch/arm/mach-stm32mp/bsec.c:368:11: warning: > comparison of unsigned expression < 0 is always false [-Wtype-limits] > 368 | if (offs < 0 || (offs % 4) || (size % 4)) > | ^ > In function ‘stm32mp_bsec_write’: > arch/arm/mach-stm32mp/bsec.c:405:11: warning: > comparison of unsigned expression < 0 is always false [-Wtype-limits] > 405 | if (offs < 0 || (offs % 4) || (size % 4)) > | ^ > > Signed-off-by: Patrick Delaunay <[email protected]> > --- > > arch/arm/mach-stm32mp/bsec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-stm32mp/bsec.c b/arch/arm/mach-stm32mp/bsec.c > index a77c706a1a..1d904caae1 100644 > --- a/arch/arm/mach-stm32mp/bsec.c > +++ b/arch/arm/mach-stm32mp/bsec.c > @@ -365,7 +365,7 @@ static int stm32mp_bsec_read(struct udevice *dev, int > offset, > shadow = false; > } > > - if (offs < 0 || (offs % 4) || (size % 4)) > + if ((offs % 4) || (size % 4)) > return -EINVAL; > > otp = offs / sizeof(u32); > @@ -402,7 +402,7 @@ static int stm32mp_bsec_write(struct udevice *dev, int > offset, > shadow = false; > } > > - if (offs < 0 || (offs % 4) || (size % 4)) > + if ((offs % 4) || (size % 4)) > return -EINVAL; > > otp = offs / sizeof(u32);
Acked-by: Patrice Chotard <[email protected]> Thanks Patrice
