Replace combination of malloc()+memset() with calloc() as the behavior
is exactly the same and the amount of code is reduced.

Signed-off-by: Marek Vasut <marek.vasut+rene...@gmail.com>
Cc: Joe Hershberger <joe.hershber...@ni.com>
Cc: Masahiro Yamada <yamada.masah...@socionext.com>
---
V2: - Use kzalloc()
    - Return -ENOMEM on alloc fail
V3: - Switch back to calloc(), it's not worth pulling in all the
      linux-compatibility complexity
V4: No change
---
 drivers/net/smc911x.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c
index 24b4eaeb3f..2c72e3469d 100644
--- a/drivers/net/smc911x.c
+++ b/drivers/net/smc911x.c
@@ -242,11 +242,9 @@ int smc911x_initialize(u8 dev_num, int base_addr)
        unsigned long addrl, addrh;
        struct eth_device *dev;
 
-       dev = malloc(sizeof(*dev));
-       if (!dev) {
-               return -1;
-       }
-       memset(dev, 0, sizeof(*dev));
+       dev = calloc(1, sizeof(*dev));
+       if (!dev)
+               return -ENOMEM;
 
        dev->iobase = base_addr;
 
-- 
2.25.1

Reply via email to