On 2010/08/12 1:43 PM, Stefan Roese wrote:
> This patch moves some MTD related defines and prototypes from a jffs2
> header to an MTD header. This makes it possible to remove this jffs2
> header inclusion from some files without jffs2 relevance.
>
> Signed-off-by: Stefan Roese<[email protected]>
> Cc: Alexander Stein<[email protected]>

Just two comments.

> +struct part_info {
> +     struct list_head link;
> +     char *name;                     /* partition name */
> +     u8 auto_name;                   /* set to 1 for generated name */
> +     u32 size;                       /* total size of the partition */
> +     u32 offset;                     /* offset within device */
> +     void *jffs2_priv;               /* used internaly by jffs2 */

Should this really be in here? Seems we are mixing things up still.

>   /* XXX U-BOOT XXX */
>   #if 0
>   struct mtd_notifier {

What's up with "#if 0" code in the src?

Rogan
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to