-----Original Message-----
From: Peter Robinson <pbrobin...@gmail.com>
Sent: Tuesday, March 31, 2020 3:54 AM
To: tomcwarren3...@gmail.com
Cc: u-boot@lists.denx.de; Stephen Warren <swar...@nvidia.com>; Thierry Reding
<tred...@nvidia.com>; Jonathan Hunter <jonath...@nvidia.com>; Tom Warren
<twar...@nvidia.com>; Vishruth Jain <vishru...@nvidia.com>
Subject: Re: [PATCH 3/3] ARM: tegra: p2371-2180: add I2C nodes to DT
External email: Use caution opening links or attachments
> From: Stephen Warren <swar...@nvidia.com>
>
> This adds to the DT the I2C controllers that connect to the board ID
> EEPROM, camera board EEPROM, etc. With this change, you can now probe
> all I2C devices on a TX1 board.
>
> Signed-off-by: Tom Warren <twar...@nvidia.com>
> ---
> arch/arm/dts/tegra210-p2371-2180.dts | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm/dts/tegra210-p2371-2180.dts
> b/arch/arm/dts/tegra210-p2371-2180.dts
> index c2f497c..d982b5f 100644
> --- a/arch/arm/dts/tegra210-p2371-2180.dts
> +++ b/arch/arm/dts/tegra210-p2371-2180.dts
> @@ -12,6 +12,9 @@
>
> aliases {
> i2c0 = "/i2c@7000d000";
> + i2c2 = "/i2c@7000c400";
> + i2c3 = "/i2c@7000c500";
> + i2c5 = "/i2c@546c0c00";
I don't think this is correct, it doesn't show up in U-Boot with the "i2c bus"
command where the others do, looking in the tegra210.dtsi it looks like it
should be i2c@546c0000?
[Tom] That I2C address is working in downstream (L4T) TX1 U-Boot. The VI_I2C
controller is a little weird, it's normal I2C registers are offset from base by
0xC00. A different driver is needed, but I haven't posted it yet upstream. I
should probably drop if from the DTS for now until I post the VI_I2C driver.
--nvpublic
> mmc0 = "/sdhci@700b0600";
> mmc1 = "/sdhci@700b0000";
> usb0 = "/usb@7d000000"; @@ -33,6 +36,11 @@
> };
> };
>
> + i2c@546c0c00 {
> + status = "okay";
> + clock-frequency = <400000>;
> + };
> +
> padctl@7009f000 {
> pinctrl-0 = <&padctl_default>;
> pinctrl-names = "default"; @@ -85,6 +93,16 @@
> non-removable;
> };
>
> + i2c@7000c400 {
> + status = "okay";
> + clock-frequency = <400000>;
> + };
> +
> + i2c@7000c500 {
> + status = "okay";
> + clock-frequency = <400000>;
> + };
> +
> i2c@7000d000 {
> status = "okay";
> clock-frequency = <400000>;
> --
> 1.8.2.1.610.g562af5b
>
>
> ----------------------------------------------------------------------
> ------------- This email message is for the sole use of the intended
> recipient(s) and may contain confidential information. Any
> unauthorized review, use, disclosure or distribution is prohibited.
> If you are not the intended recipient, please contact the sender by
> reply email and destroy all copies of the original message.
> ----------------------------------------------------------------------
> -------------
