On Fri, Apr 03, 2020 at 03:52:54AM +0000, Tan, Ley Foon wrote: > > > > -----Original Message----- > > From: Marek Vasut <[email protected]> > > Sent: Friday, April 3, 2020 6:47 AM > > To: Tom Rini <[email protected]> > > Cc: Simon Glass <[email protected]>; Ang, Chee Hong > > <[email protected]>; U-Boot Mailing List <[email protected]>; > > Simon Goldschmidt <[email protected]>; See, Chin Liang > > <[email protected]>; Tan, Ley Foon <[email protected]>; > > Westergreen, Dalon <[email protected]> > > Subject: Re: [PATCH v1 1/2] clk: socfpga: Read the clock parent's register > > base in probe function > > > > On 4/3/20 12:10 AM, Tom Rini wrote: > > > On Thu, Apr 02, 2020 at 11:07:31PM +0200, Marek Vasut wrote: > > >> On 4/2/20 10:54 PM, Tom Rini wrote: > > >> [...] > > >> > > >>>>>>>> I'm not sure it definitely should be changed. But I'll do a > > >>>>>>>> patch and see how it looks. > > >>>>>>> > > >>>>>>> Do I understand it correctly that the patch > > >>>>>>> 82de42fa14682d408da935adfb0f935354c5008f actually completely > > >>>>>>> breaks SoCFPGA ? Then I would say this is a release blocker ? > > >>>>>> Yes. A10 SPL won't boot at all. It crashes during the clock manager > > setup. > > >>>>> > > >>>>> This came in right at the beginning of the cycle. I thought the > > >>>>> purpose of the 3-month cycle was to allow time to test? > > >>>> > > >>>> It was ... altera ? > > >>> > > >>> Sorry, I'm missing how that's an answer to the question. This came > > >>> in basically right at the start of the merge window. > > >> > > >> I don't have an A10 available right now, so what can I do ? > > > > > > Ah, so the answer is "I can't test this platform myself". That's what > > > then, thanks. > > > > Clearly Altera can , since they reported this issue. > Yes, we have Arria10 devkit here and we see the issue when testing latest > uboot. > It looks like other platform [1] also encounter issue with patch > 82de42fa14682d40. Like Marek said, we don't know any other driver is broken > after this patch. > > [1] https://patchwork.ozlabs.org/patch/1265188/
Yes, my concern here is that the platform in question wasn't tested after -rc1 or -rc2 or -rc3 only right now just before release. So we're in a bit of a scramble to fix the driver. Thanks! -- Tom
signature.asc
Description: PGP signature
