On Mon, Mar 30, 2020 at 05:12:51PM -0600, Simon Glass wrote: > Add a sandbox test for the basic ACPI functionality we have so far.
> +U_BOOT_DRIVER(testacpi_drv) = {
> + .name = "testacpi_drv",
> + .of_match = testacpi_ids,
> + .id = UCLASS_TEST_ACPI,
> + acpi_ops_ptr(&testacpi_ops)
I have noticed that this is not obvious why no comma here.
Perhaps, since apci_ops_ptr is a macro, you should upper case it.
> +};
--
With Best Regards,
Andy Shevchenko

