Remove the unnecessary inversion on the eth_env_set_enetaddr() result which
only make complex the code of setup_mac_address() and display an invalid
value in the associated pr_err.

Signed-off-by: Patrick Delaunay <patrick.delau...@st.com>
---

 arch/arm/mach-stm32mp/cpu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-stm32mp/cpu.c b/arch/arm/mach-stm32mp/cpu.c
index ea0bd94605..2a9b7c1987 100644
--- a/arch/arm/mach-stm32mp/cpu.c
+++ b/arch/arm/mach-stm32mp/cpu.c
@@ -491,8 +491,8 @@ __weak int setup_mac_address(void)
                return -EINVAL;
        }
        pr_debug("OTP MAC address = %pM\n", enetaddr);
-       ret = !eth_env_set_enetaddr("ethaddr", enetaddr);
-       if (!ret)
+       ret = eth_env_set_enetaddr("ethaddr", enetaddr);
+       if (ret)
                pr_err("Failed to set mac address %pM from OTP: %d\n",
                       enetaddr, ret);
 #endif
-- 
2.17.1

Reply via email to