On Thu, Apr 9, 2020 at 1:48 AM Lokesh Vutla <[email protected]> wrote: > > > > On 26/03/20 8:56 PM, Adam Ford wrote: > > With the converstion of SMC911x to DM, this can facilitate the omap3 > > boards from LogicPD (now called Beacon EmbeddedWorks) to be converted. > > There isn't a clean solution to doing this in phases, so the boards are > > all being done together to avoid breaking functionality. > > > > Because the GPMC bus hasn't been converted, the -u-boot.dtsi node needs > > to show the address of the ethernet controller for each board. > > > > The board file, which is common betwen the OMAP35 and DM37 SOM LV and > > Torpedo boards, can remove the manual ethernet initialization, but it > > still needs to register the address and GPMC configuration for the Ethernet > > controller which is now being moved around to board_late_init(). > > > > Lastly, this patch updates the various config files to add the reference > > for DM_ETH and remove the SMC address, which is now fetched from the > > newly created device tree nodes. > > Because of this the build is not going through. It is asking to fill in the > SMC > address value as below: > > # > # configuration written to .config > # > .config:1093:warning: symbol value '' invalid for SMC911X_BASE > * > * Restart config... > * > * > * Network device support > * > Network device support (NETDEVICES) [Y/n/?] y > Enable GbE PHY status parsing and configuration (PHY_GIGE) [N/y/?] n > Altera Triple-Speed Ethernet MAC support (ALTERA_TSE) [N/y/?] n > Broadcom SF2 (Starfighter2) Ethernet support (BCM_SF2_ETH) [N/y/?] n > BCMGENET V5 support (BCMGENET) [N/y/?] n > Synopsys DWC Ethernet QOS device support (DWC_ETH_QOS) [N/y/?] n > Intel PRO/1000 Gigabit Ethernet support (E1000) [N/y/?] n > Synopsys Designware Ethernet MAC (ETH_DESIGNWARE) [N/y/?] n > OpenCores 10/100 Mbps Ethernet MAC (ETHOC) [N/y/?] n > Freescale FMan ethernet support (FMAN_ENET) [N/y/?] n > Ftmac100 Ethernet Support (FTMAC100) [N/y/?] n > Ftgmac100 Ethernet Support (FTGMAC100) [N/y/?] n > ColdFire Ethernet Support (MCFFEC) [N/y/?] n > ColdFire DMA Ethernet Support (FSLDMAFEC) [N/y/?] n > Cadence MACB/GEM Ethernet Interface (MACB) [N/y/?] n > Enable RGMII (RGMII) [N/y/?] n > Enable MII (MII) [N/y/?] n > Realtek 8139 series Ethernet controller driver (RTL8139) [N/y/?] n > Realtek 8169 series Ethernet controller driver (RTL8169) [N/y/?] n > SMSC LAN911x and LAN921x controller driver (SMC911X) [Y/n/?] y > SMC911X Base Address (SMC911X_BASE) [] (NEW) > > Can you fix it and re send the patch?
I got ahead of myself. My patch is based on a series [1] which converts SMC911X to DM_ETH. [1] - https://patchwork.ozlabs.org/cover/1261535/ Until that series is applied, my patch is premature. I'll wait until [1] is applied, then, I'll rebase my patch and re-submit as V2. Sorry about that. adam > > Thanks and regards, > Lokesh >
