On 3/31/20 6:05 PM, Marek Vasut wrote: > On 3/31/20 4:16 PM, Simon Glass wrote: >> HI Marek, > > Hi, > > [...] > >>>>>> OK I have updated the coding style page with all of this. >>>>> >>>>> Which page ? >>>> >>>> https://www.denx.de/wiki/U-Boot/CodingStyle >>> >>> " U-Boot typically uses a C structure to map out the registers in an I/O >>> region, rather than offsets. The reasons for this are: " is misleading >>> and suggests that using structures is the best practice. This should be >>> reworded to make it clear both options are equally valid. >> >> I'd like to see a preference to use struct where it makes sense and >> not use it when it doesn't, with the different tradeoffs clearly >> written. Are asking that we say nothing about which is better in each >> situation? > > Correct, because I don't see a clear agreement on which one is better > and should be preferred.
I see the wiki has still not been correctly reworded, can you please repair it ?
