Le 14/08/2010 14:19, Sergei Shtylyov a écrit : >> +#define CONFIG_SYS_ATA_DATA_OFFSET (0x0100) >> +#define CONFIG_SYS_ATA_REG_OFFSET (0x0100) >> +#define CONFIG_SYS_ATA_ALT_OFFSET (0x0100) > > The parens are useless here.
As this code comes from the mvsata_ide driver introduction, Sergei's comment also applies to edminiv2, openrd_base and the upcoming dns323 configs. However, the fix is not necessarily an urgent one; and I think it could be handled only once for all orion5x boards including edminv2 and dns323 if it is done within the SoC-specific configuration header file we've already discussed. The fix could even apply to kirkwood too, if there was a good way of defining a driver-specific configuration file and then have it included from SoC-specific config files for orion5x and kirkwood. Where could such a driver-specifc config file live? Amicalement, -- Albert. _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
