Hi Masahiro, On Mon, 13 Apr 2020 at 11:10, Masahiro Yamada <[email protected]> wrote: > > On Fri, Apr 10, 2020 at 5:18 AM Simon Glass <[email protected]> wrote: > > > > Some places use __ASSEMBLER__ instead which does not work since the > > Makefile does not define it. Fix them. > > > In my understanding, > __ASSEMBLER__ is passed by the compiler > while building *.S files. > > On which compiler didn't this work for you? > > > > > > > > Signed-off-by: Simon Glass <[email protected]> > > --- > > > > Changes in v2: > > - Add new patch to fix occurances of __ASSEMBLER__ > > > > arch/arm/include/asm/arch-fsl-layerscape/immap_lsch3.h | 2 +- > > arch/arm/include/asm/arch-mx27/regs-rtc.h | 2 +- > > arch/arm/include/asm/arch-mx5/imx-regs.h | 2 +- > > arch/arm/include/asm/arch-mx6/imx-regs.h | 2 +- > > arch/arm/include/asm/arch-mx7/imx-regs.h | 2 +- > > arch/arm/include/asm/arch-s32v234/imx-regs.h | 2 +- > > arch/arm/include/asm/arch-vf610/imx-regs.h | 2 +- > > arch/arm/mach-socfpga/include/mach/clock_manager.h | 2 +- > > arch/arm/mach-socfpga/include/mach/clock_manager_arria10.h | 4 ++-- > > arch/arm/mach-socfpga/include/mach/clock_manager_gen5.h | 4 ++-- > > arch/arm/mach-socfpga/include/mach/sdram_arria10.h | 2 +- > > arch/arm/mach-stm32mp/include/mach/stm32.h | 2 +- > > arch/x86/include/asm/mtrr.h | 2 +- > > arch/x86/include/asm/sipi.h | 4 ++-- > > include/atf_common.h | 2 +- > > include/elf.h | 4 ++-- > > 16 files changed, 20 insertions(+), 20 deletions(-) > >
I think I hit this with device tree, but I would need to go back and check. Anyway I think we should be consistent. Regards, Simon
