>-----Original Message----- >From: Biwen Li <[email protected]> >Sent: Wednesday, April 15, 2020 5:54 PM >To: Priyanka Jain (OSS) <[email protected]>; Biwen Li (OSS) ><[email protected]>; Jagdish Gediya <[email protected]>; Pramod >Kumar <[email protected]>; Shengzhou Liu ><[email protected]> >Cc: Alison Wang <[email protected]>; [email protected]; Jiafei Pan ><[email protected]> >Subject: RE: [PATCH] configs: ls1012afrwy: drop env qspi_bootcmd > >> >> >-----Original Message----- >> >From: U-Boot <[email protected]> On Behalf Of Biwen Li >> >Sent: Tuesday, March 31, 2020 1:54 PM >> >To: Jagdish Gediya <[email protected]>; Priyanka Jain >> ><[email protected]>; Pramod Kumar <[email protected]>; >> >Shengzhou Liu <[email protected]> >> >Cc: Alison Wang <[email protected]>; [email protected]; Jiafei >> >Pan <[email protected]>; Biwen Li <[email protected]> >> >Subject: [PATCH] configs: ls1012afrwy: drop env qspi_bootcmd >> > >> >From: Biwen Li <[email protected]> >> > >> >Drop useless environment variable installer and qspi_bootcmd for >> >ls1012afrwy >> > >> Please explain why these variables are useless >Only 2 MB nor flash in ls1012afrwy. So cannnot get kernel(30 MB) from the >nor flash. Thanks Biwen. Please provide this explanation in patch description. In future patches also please ensure to provided proper description for reviewers to easily review.
Regards Priyanka >> >> Thanks >> Priyanka >> >Signed-off-by: Biwen Li <[email protected]> >> >--- >> > include/configs/ls1012afrwy.h | 9 --------- >> > 1 file changed, 9 deletions(-) >> > >> >diff --git a/include/configs/ls1012afrwy.h >> >b/include/configs/ls1012afrwy.h index 9007249804..ec071d0606 100644 >> >--- a/include/configs/ls1012afrwy.h >> >+++ b/include/configs/ls1012afrwy.h >> >@@ -107,15 +107,6 @@ >> > "env exists secureboot " \ >> > "&& esbc_validate ${scripthdraddr};" \ >> > "source ${scriptaddr}\0" \ >> >- "installer=load mmc 0:2 $load_addr " \ >> >- "/flex_installer_arm64.itb; " \ >> >- "bootm $load_addr#$board\0" \ >> >- "qspi_bootcmd=pfe stop; echo Trying load from qspi..;" \ >> >- "sf probe && sf read $load_addr " \ >> >- "$kernel_addr $kernel_size; env exists secureboot " \ >> >- "&& sf read $kernelheader_addr_r $kernelheader_addr " >> > \ >> >- "$kernelheader_size && esbc_validate >> >${kernelheader_addr_r}; " \ >> >- "bootm $load_addr#$board\0" \ >> > "sd_bootcmd=pfe stop; echo Trying load from sd card..;" >> > \ >> > "mmcinfo; mmc read $load_addr " \ >> > "$kernel_addr_sd $kernel_size_sd ;" \ >> >-- >> >2.17.1
