Hi, -----"Andy Shevchenko" <[email protected]> schrieb: -----
>An: "Wolfgang Wallner" <[email protected]> >Von: "Andy Shevchenko" <[email protected]> >Datum: 21.04.2020 16:41 >Kopie: "Bin Meng" <[email protected]>, "Simon Glass" ><[email protected]>, "Andy Shevchenko" ><[email protected]>, "U-Boot Mailing List" ><[email protected]>, "Leif Lindholm" <[email protected]> >Betreff: Re: Re: [PATCH v7 1/9] acpi: Add a binding for ACPI settings >in the device tree > >On Tue, Apr 21, 2020 at 4:07 PM Wolfgang Wallner ><[email protected]> wrote: >> >Betreff: Re: [PATCH v7 1/9] acpi: Add a binding for ACPI settings >in >> >the device tree >> > >> >Hi Wolfgang, Andy, >> > >> >On Mon, Apr 20, 2020 at 4:37 AM Simon Glass <[email protected]> >wrote: >> >> >> >> Devices need to report various identifiers in the ACPI tables. >> >Rather than >> >> hard-coding these in drivers it is typically better to put them >in >> >the >> >> device tree. >> >> >> >> Add a binding file to describe this. >> >> >> >> Signed-off-by: Simon Glass <[email protected]> >> >> --- >> >> >> > >> >Do you have any comments against this patch? >> >> I'm fine with the patch as it is. >> >> However, two remarks: >> >> 1) I proposed some rewording in [1]. >> I'm fine with dropping it, I just point it out to make sure >> that it is deliberately dropped and no just overseen. >> >> 2) In [2] Andy stated that "acpi,compatible" can't work. >> @Andy: did I get this wrong? Is it still fine to add it in >> the binding? > >We can support it in the code, but user should themselves choose how >to use it. >This will be half-baked solution, though. > >So, I suggest for now to drop it completely. Ok, thanks for clarifying. That was the only aspect of the the patch I still felt I don't understand enough. So whether "acpi,compatible" is dropped or not: Reviewed-by: Wolfgang Wallner <[email protected]> >> [1] https://lists.denx.de/pipermail/u-boot/2020-April/406818.html >> [2] https://lists.denx.de/pipermail/u-boot/2020-April/406943.html > regards, Wolfgang
