On Thu, Mar 26, 2020 at 3:33 PM Kever Yang <[email protected]> wrote:
> > On 2020/3/25 下午11:37, [email protected] wrote: > > From: Suniel Mahesh <[email protected]> > > > > roc-rk3399-pc has an FE1.1 USB 2.0 HUB which connects two USB ports > > (HOST1 and HOST2). For end devices to work we need to enable USB hub > > so that HOST detects there presence and enumerates them accordingly. > > This requires explicit pinctrl within gpio enablement. > > > > Signed-off-by: Suniel Mahesh <[email protected]> > > > Reviewed-by: Kever Yang <[email protected]> > Hi Kever, This is patch is reviewed but not applied to mainline. please let me know if you need any more changes. Thanks Suniel > > Thanks, > - Kever > > --- > > Note: > > 1. tested this on roc-rk3399-pc board version roc-rk3399-pc-v1.1-a > 2018-9-25 > > 2. after this changeset, HOST1 works but HOST2 still doesnt work. I have > > tested them with linux-next, linux-rockchip and Firefly's source (both > u-boot > > and kernel), HOST2 doesn't work. > > 3. Request to test this changetest who have access to target and please > advice > > on HOST2 > > --- > > arch/arm/dts/rk3399-roc-pc-u-boot.dtsi | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/arch/arm/dts/rk3399-roc-pc-u-boot.dtsi > b/arch/arm/dts/rk3399-roc-pc-u-boot.dtsi > > index 5746442..598e0e2 100644 > > --- a/arch/arm/dts/rk3399-roc-pc-u-boot.dtsi > > +++ b/arch/arm/dts/rk3399-roc-pc-u-boot.dtsi > > @@ -14,6 +14,16 @@ > > chosen { > > u-boot,spl-boot-order = "same-as-spl", &sdhci, &sdmmc; > > }; > > + > > + vcc_hub_en: vcc_hub_en-regulator { > > + compatible = "regulator-fixed"; > > + enable-active-high; > > + gpio = <&gpio2 RK_PA4 GPIO_ACTIVE_HIGH>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&hub_rst>; > > + regulator-name = "vcc_hub_en"; > > + regulator-always-on; > > + }; > > }; > > > > &vdd_log { > > >
