Hi Wolfgang, > Dear Detlev Zundel, > > In message <[email protected]> you wrote: >> >> > You mean replace "maxspeed" by "cpuclk"? As I have noted a number of times >> > before, we are not passing the cpu clock speed here. That information >> > kernel >> > directly reads from system registers. No need to pass it from U-Boot. The >> > example you are giving is not the right comparison. >> >> Ok, then currently I would vote for "cpumaxspeed_mhz". > > Even though its pretty descriptive - for the sake of consistency I > recommend to omit the "_mhz" part.
I know that I will mutter a not so nice remark every time I use the variable and am forced to look up the documentation for a single setenv command instead of typing 4 more characters. I still remember the days of "clocks_in_mhz" and the waste of time it produced - maybe this is why I continue to raise this concern. > Also, I feel that "clock" would be more appropriate than "speed". And > we should consider that we already use "cpuclk" for very similar > purposes in U-Boot. > > Can we agree on "cpumaxclk" ? If nobody else shares my concerncs this sounds good. Cheers Detlev -- #!/usr/bin/perl $c="print\"\#\!\/usr\/bin\/perl\ \\\$c\=\\\"\"\.quotemeta\(\$c\)\.\"\\\"\;\\n\$c;\""; print"#!/usr/bin/perl\n\$c=\"".quotemeta($c)."\";\n$c;"; -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: [email protected] _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
