Hi Wasim, Thanks a lot for your review!
Regards, Zhiqiang > -----Original Message----- > From: Wasim Khan <[email protected]> > Sent: 2020年4月21日 15:38 > To: Z.q. Hou <[email protected]>; [email protected]; Priyanka Jain > <[email protected]>; Biwen Li <[email protected]> > Cc: Z.q. Hou <[email protected]> > Subject: RE: [PATCHv2 4/9] board: lx2160a: Make sure the RD tables address > align to 64KB > > > > > -----Original Message----- > > From: U-Boot <[email protected]> On Behalf Of Zhiqiang Hou > > Sent: Tuesday, March 24, 2020 1:42 PM > > To: [email protected]; Priyanka Jain <[email protected]>; Biwen > > Li <[email protected]> > > Cc: Z.q. Hou <[email protected]> > > Subject: [PATCHv2 4/9] board: lx2160a: Make sure the RD tables address > > align to 64KB > > > > From: Hou Zhiqiang <[email protected]> > > > > As the lower 16bit of the redistributor pending table is reserved for > > describing the memory attributes, we must give a 64KB aligned address > > to the GIC LPI initialization function. > > > > Signed-off-by: Hou Zhiqiang <[email protected]> > > > Reviewed-by: Wasim Khan <[email protected]> > > > --- > > V2: > > - The #5 of v1 patchset. > > > > board/freescale/lx2160a/lx2160a.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/board/freescale/lx2160a/lx2160a.c > > b/board/freescale/lx2160a/lx2160a.c > > index 7f22110dc6..c8e962ce3d 100644 > > --- a/board/freescale/lx2160a/lx2160a.c > > +++ b/board/freescale/lx2160a/lx2160a.c > > @@ -17,6 +17,7 @@ > > #include <asm/io.h> > > #include <fdt_support.h> > > #include <linux/libfdt.h> > > +#include <linux/sizes.h> > > #include <fsl-mc/fsl_mc.h> > > #include <env_internal.h> > > #include <efi_loader.h> > > @@ -678,7 +679,7 @@ int ft_board_setup(void *blob, bd_t *bd) > > } > > > > #ifdef CONFIG_GIC_V3_ITS > > - gic_lpi_base = gd->arch.resv_ram - GIC_LPI_SIZE; > > + gic_lpi_base = ALIGN(gd->arch.resv_ram - GIC_LPI_SIZE, SZ_64K); > > ret = fdt_fixup_gic_lpi_memory(blob, gic_lpi_base); > > if (!ret && gic_lpi_tables_init(gic_lpi_base, cpu_numcores())) > > debug("%s: failed to init gic-lpi-tables\n", __func__); > > -- > > 2.17.1
