Hello Jagan, of course its possible to join them to one file, share the main SPL function and co-exist. However, SPI-NAND boot isn’t that popular (for good reasons) and only very few sunxi SoCs are capable of doing so. Most of the time only one is used and the other would unnecessary bloat the (very limited) SPL. Thus I thought it would be much more readable and maintainable if those are split in multiple files and distinct functions instead of a lot of #ifdef or similar.
Anyhow, if the maintainers prefer a single file for any reason, its no big deal to reimplement the series and keep everything as one file. Im going to submit a cover-letter asap. Best Regards Benedikt > Am 01.05.2020 um 18:54 schrieb Jagan Teki <[email protected]>: > > On Tue, Apr 28, 2020 at 7:53 PM Benedikt-Alexander Mokroß > <[email protected]> wrote: >> >> This patch splits the sunxi SPI-SPL in its two components: >> - SUNXI-SPI-Handling (spl_spi_sunxi.c) >> - SPI-NOR with SPI-NOR-SPL-Logic (spl_spi_sunxi_nor.c) >> >> For this, the spl got moved in its own subdirectory. >> This prepares the SPL to support more then just SPI-NOR. >> >> Signed-off-by: Benedikt-Alexander Mokroß <[email protected]> >> --- > > Please add a cover-letter to explain why these changes require? and > also I'm still thinking it can be possible to support both SPI > NOR/NAND in the same driver. Let me comment on the next version > changes. > > Jagan.
