On Fri, May 01, 2020 at 05:40:25PM +0200, Marek Vasut wrote: > There is no reason to tail-pad fitImage with external data to 4-bytes, > while fitImage without external data does not have any such padding and > is often unaligned. DT spec also does not mandate any such padding. > > Moreover, the tail-pad fills the last few bytes with uninitialized data, > which could lead to a potential information leak. > > $ echo -n xy > /tmp/data ; \ > ./tools/mkimage -E -f auto -d /tmp/data /tmp/fitImage ; \ > hexdump -vC /tmp/fitImage | tail -n 3 > > before: > 00000260 61 2d 6f 66 66 73 65 74 00 64 61 74 61 2d 73 69 |a-offset.data-si| > 00000270 7a 65 00 00 78 79 64 64 |ze..xydd| > ^^ ^^ ^^ > after: > 00000260 61 2d 6f 66 66 73 65 74 00 64 61 74 61 2d 73 69 |a-offset.data-si| > 00000270 7a 65 00 78 79 |ze.xy| > > Signed-off-by: Marek Vasut <ma...@denx.de> > Reviewed-by: Simon Glass <s...@chromium.org> > Cc: Heinrich Schuchardt <xypron.g...@gmx.de> > Cc: Tom Rini <tr...@konsulko.com>
Applied to u-boot/master, thanks! -- Tom
signature.asc
Description: PGP signature
