Hi Simon,

On Tue, May 5, 2020 at 7:19 AM Simon Glass <s...@chromium.org> wrote:
>
> Unfortunately ARM has a lot of special stuff. Move it into the generic
> function for now, so we can have it all in one place.
>
> Add in the frame-buffer printout, since it supports driver model too.
>
> Signed-off-by: Simon Glass <s...@chromium.org>
> ---
>
>  cmd/bdinfo.c | 250 +++++++++++++++++++++------------------------------
>  1 file changed, 104 insertions(+), 146 deletions(-)
>
> diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c
> index 0e96dd619c..f07f92463c 100644
> --- a/cmd/bdinfo.c
> +++ b/cmd/bdinfo.c
> @@ -170,53 +170,8 @@ static inline void __maybe_unused print_std_bdinfo(const 
> bd_t *bd)
>  }
>
>  #if defined(CONFIG_PPC)

This commit has both PPC and ARM changes. Could them be split into 2 patches?

> -void __weak board_detail(void)
> -{
> -       /* Please define board_detail() for your platform */
> -}
> -

Regards,
Bin

Reply via email to