Re: [PATCH v7 19/22] sifive: dts: fu540: Enable L2 Cache in U-Boot

[Jagan Teki]

On Sun, May 3, 2020 at 12:57 PM Pragnesh Patel
<pragnesh.pa...@sifive.com> wrote:
>
> Hi jagan,
>
> >-----Original Message-----
> >From: Jagan Teki <ja...@amarulasolutions.com>
> >Sent: 02 May 2020 22:43
> >To: Pragnesh Patel <pragnesh.pa...@sifive.com>
> >Cc: U-Boot-Denx <u-boot@lists.denx.de>; Atish Patra
> ><atish.pa...@wdc.com>; Palmer Dabbelt <palmerdabb...@google.com>; Bin
> >Meng <bmeng...@gmail.com>; Paul Walmsley <paul.walms...@sifive.com>;
> >Troy Benjegerdes <troy.benjeger...@sifive.com>; Anup Patel
> ><anup.pa...@wdc.com>; Sagar Kadam <sagar.ka...@sifive.com>; Rick Chen
> ><r...@andestech.com>
> >Subject: Re: [PATCH v7 19/22] sifive: dts: fu540: Enable L2 Cache in U-Boot
> >
> >[External Email] Do not click links or attachments unless you recognize the
> >sender and know the content is safe
> >
> >On Sat, May 2, 2020 at 10:12 PM Pragnesh Patel <pragnesh.pa...@sifive.com>
> >wrote:
> >>
> >> Hi Jagan,
> >>
> >> >-----Original Message-----
> >> >From: Jagan Teki <ja...@amarulasolutions.com>
> >> >Sent: 02 May 2020 21:49
> >> >To: Pragnesh Patel <pragnesh.pa...@sifive.com>
> >> >Cc: U-Boot-Denx <u-boot@lists.denx.de>; Atish Patra
> >> ><atish.pa...@wdc.com>; Palmer Dabbelt <palmerdabb...@google.com>;
> >Bin
> >> >Meng <bmeng...@gmail.com>; Paul Walmsley
> ><paul.walms...@sifive.com>;
> >> >Troy Benjegerdes <troy.benjeger...@sifive.com>; Anup Patel
> >> ><anup.pa...@wdc.com>; Sagar Kadam <sagar.ka...@sifive.com>; Rick
> >Chen
> >> ><r...@andestech.com>
> >> >Subject: Re: [PATCH v7 19/22] sifive: dts: fu540: Enable L2 Cache in
> >> >U-Boot
> >> >
> >> >[External Email] Do not click links or attachments unless you
> >> >recognize the sender and know the content is safe
> >> >
> >> >On Sat, May 2, 2020 at 3:39 PM Pragnesh Patel
> >> ><pragnesh.pa...@sifive.com>
> >> >wrote:
> >> >>
> >> >> Add L2 cache node to enable cache ways from U-Boot
> >> >
> >> >This and 20/22 doesn't relate to SPL MMC boot?, if yes please send
> >> >them separately.
> >>
> >> This series is for replacing FSBL and all the patches are related to that.
> >> IMHO it's better to add all FSBL functionality in one series.
> >
> >You mean does it break existing FSBL flow? if yes add proper commit message,
> >but I am able to boot SPL MMC w/o this?
>
> Cache ways are enabled by FSBL also and if I will send cache ways patches 
> separately then it will a duplicate
> way of enabling cache ways if someone using FSBL.

Sorry I didn't get you.

If we cannot include these changes does U-Boot SPL break existing FSBL?

Jagan.