>-----Original Message----- >From: Jagan Teki <[email protected]> >Sent: 11 May 2020 12:23 >To: Pragnesh Patel <[email protected]> >Cc: U-Boot-Denx <[email protected]>; Atish Patra ><[email protected]>; Palmer Dabbelt <[email protected]>; Bin >Meng <[email protected]>; Paul Walmsley <[email protected]>; >Troy Benjegerdes <[email protected]>; Anup Patel ><[email protected]>; Sagar Kadam <[email protected]>; Rick Chen ><[email protected]> >Subject: Re: [PATCH v7 14/22] riscv: Add place-holder for driver compilation > >[External Email] Do not click links or attachments unless you recognize the >sender and know the content is safe > >On Mon, May 11, 2020 at 11:28 AM Pragnesh Patel ><[email protected]> wrote: >> >> >-----Original Message----- >> >From: Jagan Teki <[email protected]> >> >Sent: 10 May 2020 14:42 >> >To: Pragnesh Patel <[email protected]> >> >Cc: U-Boot-Denx <[email protected]>; Atish Patra >> ><[email protected]>; Palmer Dabbelt <[email protected]>; >Bin >> >Meng <[email protected]>; Paul Walmsley ><[email protected]>; >> >Troy Benjegerdes <[email protected]>; Anup Patel >> ><[email protected]>; Sagar Kadam <[email protected]>; Rick >Chen >> ><[email protected]> >> >Subject: Re: [PATCH v7 14/22] riscv: Add place-holder for driver >> >compilation >> > >> >[External Email] Do not click links or attachments unless you >> >recognize the sender and know the content is safe >> > >> >On Sun, May 3, 2020 at 2:47 PM Pragnesh Patel >> ><[email protected]> >> >wrote: >> >> >> >> Hi Jagan, >> >> >> >> >-----Original Message----- >> >> >From: Jagan Teki <[email protected]> >> >> >Sent: 02 May 2020 21:58 >> >> >To: Pragnesh Patel <[email protected]> >> >> >Cc: U-Boot-Denx <[email protected]>; Atish Patra >> >> ><[email protected]>; Palmer Dabbelt ><[email protected]>; >> >Bin >> >> >Meng <[email protected]>; Paul Walmsley >> ><[email protected]>; >> >> >Troy Benjegerdes <[email protected]>; Anup Patel >> >> ><[email protected]>; Sagar Kadam <[email protected]>; Rick >> >Chen >> >> ><[email protected]> >> >> >Subject: Re: [PATCH v7 14/22] riscv: Add place-holder for driver >> >> >compilation >> >> > >> >> >[External Email] Do not click links or attachments unless you >> >> >recognize the sender and know the content is safe >> >> > >> >> >On Sat, May 2, 2020 at 3:38 PM Pragnesh Patel >> >> ><[email protected]> >> >> >wrote: >> >> >> >> >> >> Add place-holder for RISC-V fu540 CPU >> >> >> >> >> >> Signed-off-by: Pragnesh Patel <[email protected]> >> >> >> --- >> >> >> arch/riscv/include/asm/arch-fu540/clk.h | 14 +++++++++ >> >> >> arch/riscv/include/asm/arch-fu540/gpio.h | 38 >> >> >> ++++++++++++++++++++++++ >> >> > >> >> >Where is it using exactly? >> >> >> >> "drivers/gpio/sifive-gpio.c" >> > >> >I mean which patch used these headers? >> >> This headers are necessary for existing SiFive drivers. >> >> Earlier CONFIG_SYS_CPU is "generic", so drivers use headers from " >> arch/riscv/include/asm/arch-generic/" now We have changed the >> CONFIG_SYS_CPU to "fu540" so now drivers will use headers from >"arch/riscv/include/asm/arch-fu540/". > >How can someone understand the patch if you don't have any commit >message explaining this? also add these headers to the patch that introduces >CONFIG_SYS_CPU. It makes more sense to use the code or header which are >relevant rather than a stale commit.
Okay, I will squash [v7 13/22] and [v7 14/22] and also change CONFIG_SYS_CPU to "fu540" in that patch. > >Jagan.
