On Mon, May 11, 2020 at 02:28:54PM -0600, Simon Glass wrote: > Hi Masahiro, > > On Sun, 10 May 2020 at 22:57, Masahiro Yamada <[email protected]> wrote: > > > > On Mon, May 11, 2020 at 2:43 AM Simon Glass <[email protected]> wrote: > > > > > > Some places use __ASSEMBLER__ instead which does not work since the > > > Makefile does not define it. Fix them. > > > > > > Signed-off-by: Simon Glass <[email protected]> > > > > > > I think we decided to not do this in v2, didn't we? > > > > http://patchwork.ozlabs.org/project/uboot/patch/[email protected]/ > > I must have misunderstood that thread. I think we should be consistent > in U-Boot as to which one we use. It makes it much harder to check > things when there are multiple options.
So, we should generally use __ASSMEBLY__ which is what U-Boot and Linux kernel have used for forever. I do see a handful of __ASSEMBLER__ in Linux now. That said: > > > include/atf_common.h | 2 +- atf_common.h comes from another project, so this is just going to introduce sync-noise and unlikely to matter for the binman use-case? -- Tom
signature.asc
Description: PGP signature
