Hi Masahiro,

On Tue, 19 May 2020 at 21:32, Masahiro Yamada
<yamada.masah...@socionext.com> wrote:
>
> I do not understand the changes made to these files by
> commit f7ae49fc4f36 ("common: Drop log.h from common header").
>
>   git show f7ae49fc4f36 -- arch/arm/mach-uniphier/
>
> None of them uses the log function feature.
>
> Simply revert the changes made to these files.
>
> Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com>
> ---
>
>  arch/arm/mach-uniphier/board_init.c           | 1 -
>  arch/arm/mach-uniphier/dram/ddrphy-training.c | 1 -
>  arch/arm/mach-uniphier/dram/umc-pxs2.c        | 1 -
>  arch/arm/mach-uniphier/micro-support-card.c   | 1 -
>  arch/arm/mach-uniphier/nand-reset.c           | 1 -
>  5 files changed, 5 deletions(-)
>

Reviewed-by: Simon Glass <s...@chromium.org>

Uniphier is very unusual in that it doesn't include common.h in quite
a few files. I hope by the next time we get to RC2 common.h will be
empty apart from config.h.

Regards,
Simon

Reply via email to