Hi Simon,

On Tue, 19 May 2020 17:10:44 -0600
Simon Glass s...@chromium.org wrote:

> Add a convenience function to call video_sync_copy() for a vidconsole.
> Also add a memmove() helper, which does the memmove() as well as the sync.
> 
> Signed-off-by: Simon Glass <s...@chromium.org>

Reviewed-by: Anatolij Gustschin <ag...@denx.de>

Nit below

...
> +int vidconsole_memmove(struct udevice *dev, void *dst, const void *src,
> +                    int size)
> +{
> +     int ret;
> +
> +     memmove(dst, src, size);
> +     ret = vidconsole_sync_copy(dev, dst, dst + size);
> +     if (ret)
> +             return ret;

here we can also do

        return vidconsole_sync_copy(dev, dst, dst + size);
> +
> +     return 0;
> +}
> +#endif

Reply via email to