Hi Tom

> From: Tom Rini [mailto:tr...@konsulko.com]
> Sent: Monday, May 25, 2020 11:40 PM
> To: Open Source Project uboot
> Cc: u-boot@lists.denx.de; Rick Jian-Zhi Chen(陳建志)
> Subject: Re: [U-Boot] Pull request: u-boot-riscv/master
>
> On Mon, May 25, 2020 at 04:01:08PM +0800, ub...@andestech.com wrote:
>
> > Hi Tom,
> >
> > Please pull some riscv updates:
> >
> > - Add Sipeed Maix support.
> > - sifive: fix palmer's email address.
> > - Move all SMP related SBI calls to SBI_v01.
> >
> > https://travis-ci.org/github/rickchen36/u-boot-riscv/builds/690778926
> >
> > Thanks
> > Rick
> >
> >
> > The following changes since commit 9c5fef577494769e3ff07952a85f9b7125ef765b:
> >
> >   Merge git://git.denx.de/u-boot-usb (2020-05-22 22:58:50 -0400)
> >
> > are available in the Git repository at:
> >
> >   g...@gitlab.denx.de:u-boot/custodians/u-boot-riscv.git
> >
> > for you to fetch changes up to 421c4eb2dcf39f65c31c1804369267ed8a7b5607:
> >
> >   riscv: Add Sipeed Maix support (2020-05-25 10:01:21 +0800)
> >
>
> There's too many generic changes in this PR for this late in the cycle, for 
> things I gather related to the Maix platform.  All of the clk and DM changes 
> impact virtually all platforms.  Please re-do this PR to drop the Maix 
> platform support for now, and resubmit that for -next, which I will be 
> opening shortly.  Everything else however is good for master.

Thanks for your explanations.
Actually I have the same concern with you before sending this PR.

I have tried to ask Sean don't mix all codes together in one patchset.
He shall separate and send them individually, If they are not highly dependent.

Following are my suggestions from those patch-work:

Re: [PATCH v2 01/11] clk: Always use the supplied struct clk
https://patchwork.ozlabs.org/project/uboot/patch/da401261-b73f-afae-0702-ada1e7dd8...@gmail.com/

Re: [PATCH v4 07/17] spi: dw: Add mem_ops
https://patchwork.ozlabs.org/project/uboot/patch/20200211060425.1619471-8-sean...@gmail.com/

Re: [PATCH v5 33/33] riscv: Add Sipeed Maix support
http://u-boot.10912.n7.nabble.com/PATCH-v5-00-33-riscv-Add-Sipeed-Maix-support-tt401784.html#a402055

Re: [PATCH v6 04/19] clk: Add functions to register CCF clock structs
https://patchwork.ozlabs.org/project/uboot/patch/20200305181308.944595-5-sean...@gmail.com/

I will drop the Maix platform support in next PR and re-send again.

Thanks,
Rick


> Sorry.
>
> --
> Tom

Reply via email to