[PATCHv2] checkpatch.pl: Add check for defining CONFIG_CMD_xxx via config files

[Tom Rini]

All of our cmds have a Kconfig entry.  Making enabling a CMD via the
config file an error to checkpatch.pl.

Signed-off-by: Tom Rini <tr...@konsulko.com>
---
Changes in v2:
- Rebase on Simon's update that adds a u-boot section
- Catch undef as well
- Have a more generic message
---
 scripts/checkpatch.pl | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 33ec4e2bfd44..cabb072a0de9 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2265,6 +2265,12 @@ sub u_boot_line {
                WARN("PREFER_IF",
                     "Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or 
#ifdef' where possible\n" . $herecurr);
        }
+
+       # use defconfig to manage CONFIG_CMD options
+       if ($line =~ /\+\s*#\s*(define|undef)\s+(CONFIG_CMD\w*)\b/) {
+               ERROR("DEFINE_CONFIG_CMD",
+                     "All commands are managed by Kconfig\n" . $herecurr);
+       }
 }
 
 sub process {
-- 
2.17.1