Hi Pragnesh, On Mon, 25 May 2020 at 23:10, Pragnesh Patel <pragnesh.pa...@sifive.com> wrote: > > Hi Simon, > > >-----Original Message----- > >From: Simon Glass <s...@chromium.org> > >Sent: 26 May 2020 03:15 > >To: Pragnesh Patel <pragnesh.pa...@sifive.com> > >Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Atish Patra > ><atish.pa...@wdc.com>; Palmer Dabbelt <palmerdabb...@google.com>; Bin > >Meng <bmeng...@gmail.com>; Paul Walmsley <paul.walms...@sifive.com>; > >Jagan Teki <ja...@amarulasolutions.com>; Anup Patel > ><anup.pa...@wdc.com>; Sagar Kadam <sagar.ka...@sifive.com>; rick > ><r...@andestech.com>; Tero Kristo <t-kri...@ti.com>; Heiko Stuebner > ><heiko.stueb...@theobroma-systems.com>; Finley Xiao <finley.xiao@rock- > >chips.com>; Adam Ford <aford...@gmail.com>; Peng Fan > ><peng....@nxp.com>; Eugen Hristev <eugen.hris...@microchip.com> > >Subject: Re: [PATCH v12 01/18] misc: add driver for the SiFive otp controller > > > >[External Email] Do not click links or attachments unless you recognize the > >sender and know the content is safe > > > >Hi Pragnesh, > > > >On Mon, 25 May 2020 at 01:34, Pragnesh Patel <pragnesh.pa...@sifive.com> > >wrote: > >> > >> Added a misc driver to handle OTP memory in SiFive SoCs. > >> > >> Signed-off-by: Pragnesh Patel <pragnesh.pa...@sifive.com> > >> Reviewed-by: Bin Meng <bmeng...@gmail.com> > >> Tested-by: Bin Meng <bmeng...@gmail.com> > >> Reviewed-by: Jagan Teki <ja...@amarulasolutions.com> > >> Tested-by: Jagan Teki <ja...@amarulasolutions.com> > >> --- > >> drivers/misc/Kconfig | 7 + > >> drivers/misc/Makefile | 1 + > >> drivers/misc/sifive-otp.c | 275 > >++++++++++++++++++++++++++++++++++++++ > >> 3 files changed, 283 insertions(+) > >> create mode 100644 drivers/misc/sifive-otp.c > > > >Did you miss the change log here? > > For this series I am just updating the cover letter for change log. > > My apology for not updating the change log in every patch but I will > definitely > take care this in future. > > For your reference, > > Changes in v12 for this patch: > > - Added necessary include files which are not part of common header now > > drivers/misc/sifive-otp.c > +#include <linux/bitops.h> > +#include <linux/delay.h>
OK...you can save yourself some work by using patman to send your patches. It handles putting the change-log from each commit into the cover letter. Regards, SImon
