Hi Pragnesh, On Mon, 25 May 2020 at 23:10, Pragnesh Patel <[email protected]> wrote: > > Hi Simon, > > >-----Original Message----- > >From: Simon Glass <[email protected]> > >Sent: 26 May 2020 03:15 > >To: Pragnesh Patel <[email protected]> > >Cc: U-Boot Mailing List <[email protected]>; Atish Patra > ><[email protected]>; Palmer Dabbelt <[email protected]>; Bin > >Meng <[email protected]>; Paul Walmsley <[email protected]>; > >Jagan Teki <[email protected]>; Anup Patel > ><[email protected]>; Sagar Kadam <[email protected]>; rick > ><[email protected]>; Tero Kristo <[email protected]>; Heiko Stuebner > ><[email protected]>; Finley Xiao <finley.xiao@rock- > >chips.com>; Adam Ford <[email protected]>; Peng Fan > ><[email protected]>; Eugen Hristev <[email protected]> > >Subject: Re: [PATCH v12 01/18] misc: add driver for the SiFive otp controller > > > >[External Email] Do not click links or attachments unless you recognize the > >sender and know the content is safe > > > >Hi Pragnesh, > > > >On Mon, 25 May 2020 at 01:34, Pragnesh Patel <[email protected]> > >wrote: > >> > >> Added a misc driver to handle OTP memory in SiFive SoCs. > >> > >> Signed-off-by: Pragnesh Patel <[email protected]> > >> Reviewed-by: Bin Meng <[email protected]> > >> Tested-by: Bin Meng <[email protected]> > >> Reviewed-by: Jagan Teki <[email protected]> > >> Tested-by: Jagan Teki <[email protected]> > >> --- > >> drivers/misc/Kconfig | 7 + > >> drivers/misc/Makefile | 1 + > >> drivers/misc/sifive-otp.c | 275 > >++++++++++++++++++++++++++++++++++++++ > >> 3 files changed, 283 insertions(+) > >> create mode 100644 drivers/misc/sifive-otp.c > > > >Did you miss the change log here? > > For this series I am just updating the cover letter for change log. > > My apology for not updating the change log in every patch but I will > definitely > take care this in future. > > For your reference, > > Changes in v12 for this patch: > > - Added necessary include files which are not part of common header now > > drivers/misc/sifive-otp.c > +#include <linux/bitops.h> > +#include <linux/delay.h>
OK...you can save yourself some work by using patman to send your patches. It handles putting the change-log from each commit into the cover letter. Regards, SImon
