Hi Stefan, On Tue, 26 May 2020 at 06:13, Stefan Roese <s...@denx.de> wrote: > > From: Suneel Garapati <sgarap...@marvell.com> > > Add support for I2C controllers found on Octeon II/III and Octeon TX > TX2 SoC platforms. > > Signed-off-by: Aaron Williams <awilli...@marvell.com> > Signed-off-by: Suneel Garapati <sgarap...@marvell.com> > Signed-off-by: Stefan Roese <s...@denx.de> > Cc: Heiko Schocher <h...@denx.de> > Cc: Simon Glass <s...@chromium.org> > Cc: Daniel Schwierzeck <daniel.schwierz...@gmail.com> > Cc: Aaron Williams <awilli...@marvell.com> > Cc: Chandrakala Chavva <ccha...@marvell.com> > --- > v2 (Stefan): > - Added clk framework support and dropped ad-hoc clock code > - Removed #ifdef's for Octeon vs OcteonTX/TX2 completely > The differentiation is now made via driver data / compatible > string > - Added device-tree bindings documentation > - Removed unused macro > > RFC -> v1 (Stefan): > - Separated this patch from the OcteonTX/TX2 RFC patch series into a > single patch. This is useful, as the upcoming MIPS Octeon support will > use this I2C driver. > - Added MIPS Octeon II/III support (big endian). Rename driver and its > function names from "octeontx" to "octeon" to better match all Octeon > platforms. > - Moved from union to defines / bitmasks as suggested by Simon. This makes > the driver usage on little- and big-endian platforms much easier. > - Enhanced Kconfig text > - Removed all clock macros (use values from DT) > - Removed long driver debug strings. This is only available when a debug > version of this driver is built. The user / developer can lookup the > descriptive error messages in the driver in this case anyway. > - Removed static "last_id" > - Dropped misc blank lines. Misc reformatting. > - Dropped "!= 0" > - Added missing function comments > - Added missing strut comments > - Changed comment style > - Renames "result" to "ret" > - Hex numbers uppercase > - Minor other changes > - Reword commit text and subject > > doc/device-tree-bindings/i2c/octeon-i2c.txt | 24 + > drivers/i2c/Kconfig | 10 + > drivers/i2c/Makefile | 1 + > drivers/i2c/octeon_i2c.c | 847 ++++++++++++++++++++ > 4 files changed, 882 insertions(+) > create mode 100644 doc/device-tree-bindings/i2c/octeon-i2c.txt > create mode 100644 drivers/i2c/octeon_i2c.c >
Reviewed-by: Simon Glass <s...@chromium.org>