Hi Jagan,
On 6/10/20 8:43 PM, Jagan Teki wrote:
> SDHCI HISPD bits need to be configured based on desired mmc
> timings mode and some HISPD quirks.
>
> So, handle the HISPD bit based on the mmc computed selected
> mode(timing parameter) rather than fixed mmc card clock
> frequency.
>
> Linux handle the HISPD similar like this in below commit,
>
> commit <501639bf2173> ("mmc: sdhci: fix SDHCI_QUIRK_NO_HISPD_BIT handling")
>
> This eventually fixed the mmc write issue observed in
> rk3399 sdhci controller.
>
> Bug log for refernece,
> => gpt write mmc 0 $partitions
> Writing GPT: mmc write failed
> ** Can't write to device 0 **
> ** Can't write to device 0 **
> error!
>
> Cc: Robin Murphy <[email protected]>
> Cc: Kever Yang <[email protected]>
> Cc: Peng Fan <[email protected]>
> Reviewed-by: Jaehoon Chung <[email protected]>
> Tested-by: Marc Zyngier <[email protected]> # nanopc-t4
> Tested-by: Suniel Mahesh <[email protected]> # roc-rk3399-pc
> Signed-off-by: Jagan Teki <[email protected]>
> ---
> Changes for v3:
> - use && for quirk check.
>
> drivers/mmc/sdhci.c | 23 +++++++++++++++--------
> 1 file changed, 15 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c
> index 92cc8434af..a7db278a0e 100644
> --- a/drivers/mmc/sdhci.c
> +++ b/drivers/mmc/sdhci.c
> @@ -594,14 +594,21 @@ static int sdhci_set_ios(struct mmc *mmc)
> ctrl &= ~SDHCI_CTRL_4BITBUS;
> }
>
> - if (mmc->clock > 26000000)
> - ctrl |= SDHCI_CTRL_HISPD;
> - else
> - ctrl &= ~SDHCI_CTRL_HISPD;
> -
> - if ((host->quirks & SDHCI_QUIRK_NO_HISPD_BIT) ||
> - (host->quirks & SDHCI_QUIRK_BROKEN_HISPD_MODE))
> - ctrl &= ~SDHCI_CTRL_HISPD;
> + if (!(host->quirks & SDHCI_QUIRK_NO_HISPD_BIT) &&
> + !(host->quirks & SDHCI_QUIRK_BROKEN_HISPD_MODE)) {
Sorry, it needs to check more. Because it's different with kernel code.
Kernel code is only checking condition about SDHCI_QUIRK_NO_HISPD_BIT.
but in u-boot, one more checking about SDHCI_QUIRK_BROKEN_HISPD_MODE.
So if it doesn't set to both, it's possible to set SDHCI_CTRL_HISPD as ctrl's
flags.
> + if (mmc->selected_mode == MMC_HS ||
> + mmc->selected_mode == SD_HS ||
> + mmc->selected_mode == MMC_DDR_52 ||
> + mmc->selected_mode == MMC_HS_200 ||
> + mmc->selected_mode == MMC_HS_400 ||
> + mmc->selected_mode == UHS_SDR25 ||
> + mmc->selected_mode == UHS_SDR50 ||
> + mmc->selected_mode == UHS_SDR104 ||
> + mmc->selected_mode == UHS_DDR50)
> + ctrl |= SDHCI_CTRL_HISPD;
> + else
> + ctrl &= ~SDHCI_CTRL_HISPD;
> + }
>
I think that needs to add at here
else
ctrl &= ~SDHCI_CTRL_HISPD;
> sdhci_writeb(host, ctrl, SDHCI_HOST_CONTROL);
>
>
