Dear [email protected],
In message <[email protected]> you wrote:
> From: Tirumala Marri <[email protected]>
>
> Add support code for bluestone board wth APM82XXX processor based.
> This patch includes early board init, misc init, configure EBC,
> initializes UIC, MAKEALL, board.cfg and MAINTAINERS file.
>
> Signed-off-by: Tirumala R Marri <[email protected]>
...
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -253,6 +253,9 @@ Feng Kan <[email protected]>
>
> redwood PPC4xx
>
> +Tirumala Marri <[email protected]>
> + bluestone APM82XXX
> +
> Brad Kemp <[email protected]>
Please keep list sorted.
> +int checkboard(void)
> +{
> + char *s = getenv("serial#");
> +
> + printf("Board: Bluestone Evaluation Board");
Use puts() if no formatting is needed.
> + if (s != NULL) {
> + puts(", serial# ");
> + puts(s);
> + }
> + putc('\n');
> +/**************************************************************************
> + * TLB TABLE
> + *
> + * This table is used by the cpu boot code to setup the initial tlb
> + * entries. Rather than make broad assumptions in the cpu source tree,
> + * this table lets each board set things up however they like.
> + *
> + * Pointer to the table is returned in r1
> + *
> + *************************************************************************/
Incorrect multiline comment style.
...
> +#define SPD_EEPROM_ADDRESS {0x53, 0x51} /* SPD i2c spd addresses */
...
> +#define CONFIG_SYS_I2C_EEPROM_ADDR (0xa8 >> 1)
...
> +#define CONFIG_4xx_CONFIG_I2C_EEPROM_ADDR 0x52
For consistency with the other settings, please convert
the "0xa8 >> 1" into 0x54.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]
When all is said and done, more is said than done.
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot
