Hi Simon, On Mon, Jun 15, 2020 at 11:57 AM Simon Glass <[email protected]> wrote: > > Add devicetree bindings for the Intel Non-High-Definition-Audio Link Table > (NHLT). > > Signed-off-by: Simon Glass <[email protected]> > --- > > include/dt-bindings/sound/nhlt.h | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > create mode 100644 include/dt-bindings/sound/nhlt.h > > diff --git a/include/dt-bindings/sound/nhlt.h > b/include/dt-bindings/sound/nhlt.h > new file mode 100644 > index 0000000000..c33f874966 > --- /dev/null > +++ b/include/dt-bindings/sound/nhlt.h > @@ -0,0 +1,23 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright 2019 Google LLC > + */ > + > +#ifndef _DT_BINDINGS_SOUND_NHLT_H > +#define _DT_BINDINGS_SOUND_NHLT_H > + > +#define NHLT_VID 0x8086 > +#define NHLT_DID_DMIC 0xae20 > +#define NHLT_DID_BT 0xae30 > +#define NHLT_DID_SSP 0xae34
These look like PCI vendor ID (0x8086 for Intel) and device IDs. If they are device IDs, how could they be fixed? > + > +/* Hardware links available to use for codecs */ > +#define AUDIO_LINK_SSP0 0 > +#define AUDIO_LINK_SSP1 1 > +#define AUDIO_LINK_SSP2 2 > +#define AUDIO_LINK_SSP3 3 > +#define AUDIO_LINK_SSP4 4 > +#define AUDIO_LINK_SSP5 5 > +#define AUDIO_LINK_DMIC 6 > + > +#endif /* _DT_BINDINGS_SOUND_NHLT_H */ > -- Regards, Bin

