Hi Bin, On Tue, 30 Jun 2020 at 02:27, Bin Meng <bmeng...@gmail.com> wrote: > > Hi Simon, > > On Mon, Jun 15, 2020 at 11:58 AM Simon Glass <s...@chromium.org> wrote: > > > > These registers need to be accesses from ACPI code, so move them to the > > header file. > > > > I don't think these are common offset to every platform.
That's right, but they are common to the boards that use this uclass and driver - I am only moving them. If we end up supporting more SoCs we may need a way to specify this in the DT or through a driver, but for now, I'm just moving from the uclass to the header. Regards, Simon