On Fri, 10 Jul 2020 at 04:51, Rayagonda Kokatanur <[email protected]> wrote: > > From: Vikas Gupta <[email protected]> > > Add optee based bnxt fw load driver. > bnxt is Broadcom NetXtreme controller Ethernet card. > This driver is used to load bnxt firmware binary using OpTEE. > > Signed-off-by: Vikas Gupta <[email protected]> > Signed-off-by: Rayagonda Kokatanur <[email protected]> > --- > Changes from v3: > -Address review comments from Simon, > Rearrange code and remove while loop, > Add comments for function. > > Changes from v2: > -Address review comments from Simon, > Remove own return code and use standard error code. > Take out common lines from different functions and move them > into common static function. > Remove include <common.h> as its not required. > Move functions with printf from header file into c file. > > drivers/tee/Kconfig | 1 + > drivers/tee/Makefile | 1 + > drivers/tee/broadcom/Kconfig | 7 ++ > drivers/tee/broadcom/Makefile | 3 + > drivers/tee/broadcom/chimp_optee.c | 180 +++++++++++++++++++++++++++++ > include/broadcom/chimp.h | 43 +++++++ > 6 files changed, 235 insertions(+) > create mode 100644 drivers/tee/broadcom/Kconfig > create mode 100644 drivers/tee/broadcom/Makefile > create mode 100644 drivers/tee/broadcom/chimp_optee.c > create mode 100644 include/broadcom/chimp.h
Reviewed-by: Simon Glass <[email protected]> Blank line before last 'return' please.
