Hi Rick, Any comments on this patch ?
>-----Original Message----- >From: U-Boot <[email protected]> On Behalf Of Pragnesh Patel >Sent: 24 June 2020 13:14 >To: Bin Meng <[email protected]>; Rick Chen <[email protected]> >Cc: U-Boot Mailing List <[email protected]>; Atish Patra ><[email protected]>; [email protected]; Paul Walmsley ( Sifive) ><[email protected]>; Anup Patel <[email protected]>; Sagar >Kadam <[email protected]>; Palmer Dabbelt <[email protected]>; >Jagan Teki <[email protected]>; rick <[email protected]>; Alan >Kao <[email protected]> >Subject: RE: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver > >Hi Rick, > >>-----Original Message----- >>From: Bin Meng <[email protected]> >>Sent: 24 June 2020 13:04 >>To: Rick Chen <[email protected]> >>Cc: Pragnesh Patel <[email protected]>; U-Boot Mailing List <u- >>[email protected]>; Atish Patra <[email protected]>; >>[email protected]; Paul Walmsley ( Sifive) >><[email protected]>; Anup Patel <[email protected]>; Sagar >>Kadam <[email protected]>; Palmer Dabbelt ><[email protected]>; >>Jagan Teki <[email protected]>; rick <[email protected]>; >>Alan Kao <[email protected]> >>Subject: Re: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM driver >> >>[External Email] Do not click links or attachments unless you recognize >>the sender and know the content is safe >> >>Hi Rick, >> >>On Wed, Jun 24, 2020 at 2:26 PM Rick Chen <[email protected]> wrote: >>> >>> Hi Bin >>> >>> > Hi Rick, >>> > >>> > On Wed, Jun 24, 2020 at 1:24 PM Pragnesh Patel >>> > <[email protected]> wrote: >>> > > >>> > > Hi Rick, >>> > > >>> > > >-----Original Message----- >>> > > >From: Rick Chen <[email protected]> >>> > > >Sent: 24 June 2020 10:44 >>> > > >To: Pragnesh Patel <[email protected]> >>> > > >Cc: U-Boot Mailing List <[email protected]>; Atish Patra >>> > > ><[email protected]>; [email protected]; Bin Meng >>> > > ><[email protected]>; Paul Walmsley ( Sifive) >>> > > ><[email protected]>; Anup Patel <[email protected]>; >>> > > >Sagar Kadam <[email protected]>; Palmer Dabbelt >>> > > ><[email protected]>; Jagan Teki <[email protected]>; >>> > > >rick <[email protected]>; Alan Kao <[email protected]> >>> > > >Subject: Re: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive PWM >>> > > >driver >>> > > > >>> > > >[External Email] Do not click links or attachments unless you >>> > > >recognize the sender and know the content is safe >>> > > > >>> > > >Hi Pragnesh >>> > > > >>> > > >> Hi Rick, >>> > > >> >>> > > >> >-----Original Message----- >>> > > >> >From: Rick Chen <[email protected]> >>> > > >> >Sent: 24 June 2020 06:30 >>> > > >> >To: Pragnesh Patel <[email protected]> >>> > > >> >Cc: U-Boot Mailing List <[email protected]>; Atish Patra >>> > > >> ><[email protected]>; [email protected]; Bin Meng >>> > > >> ><[email protected]>; Paul Walmsley ( Sifive) >>> > > >> ><[email protected]>; Anup Patel ><[email protected]>; >>> > > >> >Sagar Kadam <[email protected]>; Palmer Dabbelt >>> > > ><[email protected]>; >>> > > >> >Jagan Teki <[email protected]>; rick >>> > > >> ><[email protected]>; Alan Kao <[email protected]> >>> > > >> >Subject: Re: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive >>> > > >> >PWM driver >>> > > >> > >>> > > >> >[External Email] Do not click links or attachments unless you >>> > > >> >recognize the sender and know the content is safe >>> > > >> > >>> > > >> >Hi Pragnesh >>> > > >> > >>> > > >> >> From: Pragnesh Patel [mailto:[email protected]] >>> > > >> >> Sent: Friday, May 29, 2020 2:45 PM >>> > > >> >> To: [email protected] >>> > > >> >> Cc: [email protected]; [email protected]; >>> > > >> >[email protected]; [email protected]; >>> > > >> >[email protected]; [email protected]; Rick Jian-Zhi >>> > > >> >Chen(陳建志); Pragnesh Patel; Palmer Dabbelt >>> > > >> >> Subject: [PATCH 2/2] riscv: sifive: fu540: Enable SiFive >>> > > >> >> PWM driver >>> > > >> >> >>> > > >> >> This patch enables SiFive PWM driver for the SiFive >>> > > >> >> Unleashed >>board. >>> > > >> >> >>> > > >> >> Signed-off-by: Pragnesh Patel <[email protected]> >>> > > >> >> --- >>> > > >> >> board/sifive/fu540/Kconfig | 2 ++ >>> > > >> >> 1 file changed, 2 insertions(+) >>> > > >> >> >>> > > >> >> diff --git a/board/sifive/fu540/Kconfig >>> > > >> >> b/board/sifive/fu540/Kconfig index >>> > > >> >86193d7668..683668d059 100644 >>> > > >> >> --- a/board/sifive/fu540/Kconfig >>> > > >> >> +++ b/board/sifive/fu540/Kconfig >>> > > >> >> @@ -65,5 +65,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy >>> > > >> >> imply SMP >>> > > >> >> imply MISC >>> > > >> >> imply SIFIVE_OTP >>> > > >> >> + imply DM_PWM >>> > > >> >> + imply PWM_SIFIVE >>> > > >> >> >>> > > >> > >>> > > >> >This patch shall follow [PATCH v2 0/2] Add support for PWM SiFive. >>> > > >> >It is weird to introduce here and not appropriate to depend >>> > > >> >on another >>> > > >patch. >>> > > >> >>> > > >> Do you want me to send this 2 patches separately independent >>> > > >> of each >>> > > >other ? >>> > > > >>> > > >How about merged [PATCH 2/2] riscv: sifive: fu540: Enable SiFive >>> > > >PWM driver into [PATCH v2 0/2] Add support for PWM SiFive ? >>> > > >>> > > I am okay with it, you can go ahead and merge this patch into PWM >>series of Yash. >>> > > >>> > >>> > They are separate patches and should keep separate. I am not sure >>> > what's the issue we want to resolve? >>> >>> Nothing about resolve. >>> Logically if they can be put together, it will be more reasonable. >> >>Agree. Thanks for the clarification. >> >>That's why I recommend developers submit all related patch sets in a >>series to help maintainers' work :) > >Just to clarify, you are going to merge this patch into [PATCH v2 0/2] Add >support for PWM SiFive, right ? >Let me know if I am wrong and you want to resubmit anything from me. > >> >>Regards, >>Bin
